[webkit-reviews] review denied: [Bug 73626] Web Inspector: [Audits] Implement "Stop" button and progress bar instead of spinner. : [Attachment 117622] [PATCH] Added localized string "Stop"

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 73626: Web Inspector: [Audits] Implement "Stop" button and progress bar
instead of spinner.
https://bugs.webkit.org/show_bug.cgi?id=73626

Attachment 117622: [PATCH] Added localized string "Stop"
https://bugs.webkit.org/attachment.cgi?id=117622&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117622&action=review


> Source/WebCore/inspector/front-end/AuditLauncherView.js:137
> +	       this._stopRequested = true;

I don't see the audit rule code that is querying for stopRequested prior to
continuing execution. "Cancel" is usually implemented as a part of the progress
indicator API:

// some rule body example:

progress.setTotalWork(Object.keys(nodes).length);

for (node in nodes) {
    if (progress.isCanceled())
	return;
    progress.worked(1);
    // process node.
}