[webkit-reviews] review granted: [Bug 73730] <video> elements should disable the system and display sleep when playing on OS X. : [Attachment 117746] Patch

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 73730: <video> elements should disable the system and display sleep when
playing on OS X.
https://bugs.webkit.org/show_bug.cgi?id=73730

Attachment 117746: Patch
https://bugs.webkit.org/attachment.cgi?id=117746&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=117746&action=review


> Source/WebCore/html/HTMLMediaElement.cpp:2508
> +	   m_sleepDisabler =
DisplaySleepDisabler::create("WebCore::HTMLMediaElement playback");

The reason for the power assertion doesn’t match the format used elsewhere in
WebKit. It would be good to be consistent.