[webkit-reviews] review denied: [Bug 53001] m_mediaElement of MediaControlElement family should be removed. : [Attachment 117550] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 1 21:04:17 PST 2011


Kent Tamura <tkent at chromium.org> has denied MORITA Hajime
<morrita at google.com>'s request for review:
Bug 53001: m_mediaElement of MediaControlElement family should be removed.
https://bugs.webkit.org/show_bug.cgi?id=53001

Attachment 117550: Patch
https://bugs.webkit.org/attachment.cgi?id=117550&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117550&action=review


r- because of Chromium build failure.

> Source/WebCore/html/shadow/MediaControls.cpp:42
> +    Element* host =
toShadowRoot(shadowNode->shadowTreeRootNode())->shadowHost();

You can use Node::shadowAncestorNode().


More information about the webkit-reviews mailing list