[webkit-reviews] review denied: [Bug 73617] [Chromium] Remove hard-coded memory limits from TextureManager : [Attachment 117556] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Eric Penner
<epenner at chromium.org>'s request for review:
Bug 73617: [Chromium] Remove hard-coded memory limits from TextureManager
https://bugs.webkit.org/show_bug.cgi?id=73617

Attachment 117556: Patch
https://bugs.webkit.org/attachment.cgi?id=117556&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117556&action=review


This feels even more complicated to me, to be honest.  I really preferred
having the TextureManager only internally care about one limit at a time and
having the caller be responsible for adjusting that limit at the appropriate
times.	This moves complexity into the TextureManager implementation and adds a
whole lot more knobs to CCSettings than seem practical without exposing the
knobs that you really would want - like allowing the limit to be a multiple of
the viewport size.

Let's continue to iterate on https://bugs.webkit.org/show_bug.cgi?id=72202.

> Source/WebCore/platform/graphics/chromium/TextureManager.h:66
> +    void setHighMemoryLimitBytes(size_t);
> +    size_t highMemoryLimitBytes() { return m_highMemoryLimitBytes; }
> +
> +    void setReclaimMemoryLimitBytes(size_t bytes) {
m_reclaimMemoryLimitBytes = bytes; }
> +    size_t reclaimMemoryLimitBytes() { return m_reclaimMemoryLimitBytes; }
> +
> +    void setLowMemoryLimitBytes(size_t bytes) { m_lowMemoryLimitBytes =
bytes; }
> +    size_t lowMemoryLimitBytes() { return m_lowMemoryLimitBytes; }

why does one setter release memory while the other two setters do not?