[webkit-reviews] review denied: [Bug 67193] Web Inspector: Inspected page sometimes crashes in InspectorResourceAgent::didFailLoading : [Attachment 105613] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 30 06:41:52 PDT 2011


Yury Semikhatsky <yurys at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 67193: Web Inspector: Inspected page sometimes crashes in
InspectorResourceAgent::didFailLoading
https://bugs.webkit.org/show_bug.cgi?id=67193

Attachment 105613: Patch
https://bugs.webkit.org/attachment.cgi?id=105613&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105613&action=review


> Source/WebCore/inspector/InspectorResourceAgent.cpp:294
> +    if (!loader || !loader->frame())

All this check should be in if (m_resourcesData->resourceType(requestId) ==
InspectorPageAgent::DocumentResource), shouldn't them?


More information about the webkit-reviews mailing list