[webkit-reviews] review denied: [Bug 67198] Web Inspector: console view does a style recalculation per each addMessage call : [Attachment 105620] [patch] initial version

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 67198: Web Inspector: console view does a style recalculation per each
addMessage call
https://bugs.webkit.org/show_bug.cgi?id=67198

Attachment 105620: [patch] initial version
https://bugs.webkit.org/attachment.cgi?id=105620&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105620&action=review


>>> Source/WebCore/inspector/front-end/ConsoleView.js:286
>>> +	     if (!this._isScrollIntoViewScheduled() && ((msg instanceof
WebInspector.ConsoleCommandResult) ||
this.messagesElement.isScrolledToBottom()))
>> 
>> this._scrollIntoViewTimer is already checked in _scheduleScrollIntoView(),
isn't it?
> 
> the problem is in this.messagesElement.isScrolledToBottom call. This call is
forcing style recalculation. 
> In the old code we do style recalculation even if we already scheduled the
scroll action.

isScrolledToBottom() should be called *before* the new message has been added.