[webkit-reviews] review denied: [Bug 66492] [chromium] Separate platform gesture events from synthetic gestures : [Attachment 105494] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Robert Kroeger
<rjkroege at chromium.org>'s request for review:
Bug 66492: [chromium] Separate platform gesture events from synthetic gestures
https://bugs.webkit.org/show_bug.cgi?id=66492

Attachment 105494: Patch
https://bugs.webkit.org/attachment.cgi?id=105494&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105494&action=review


I think we should avoid overloading the term "synthetic event".  That already
means events created from document.createEvent() via script.

> Source/WebKit/chromium/src/WebInputEventConversion.cpp:-132
> -    m_shiftKey = (e.modifiers & WebInputEvent::ShiftKey);

why do these lines get deleted?