[webkit-reviews] review granted: [Bug 67050] Skia's accel canvas implementation should use GrTexture, not DrawingBuffer : [Attachment 105488] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 67050: Skia's accel canvas implementation should use GrTexture, not
DrawingBuffer
https://bugs.webkit.org/show_bug.cgi?id=67050

Attachment 105488: Patch
https://bugs.webkit.org/attachment.cgi?id=105488&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=105488&action=review


Revision looks good to me.

> Source/WebCore/platform/graphics/chromium/Canvas2DLayerChromium.cpp:74
> +	       m_context->makeContextCurrent();

According to current semantics this could actually go into the #if USE(SKIA)
block, because it only has an effect when interacting with external code (like
Ganesh) using the GC3D's underlying OpenGL context. The call to
m_context->flush() below will implicitly make the context current.