[webkit-reviews] review granted: [Bug 66018] Plumb params CachedResourceLoader to SubresourceLoader : [Attachment 105399] patch using ResourceLoaderOptions

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 66018: Plumb params CachedResourceLoader to SubresourceLoader
https://bugs.webkit.org/show_bug.cgi?id=66018

Attachment 105399: patch using ResourceLoaderOptions
https://bugs.webkit.org/attachment.cgi?id=105399&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=105399&action=review


r=me

> Source/WebCore/loader/cache/CachedResourceLoader.cpp:175
> +   
userSheet->setResourceLoaderOptions(ResourceLoaderOptions(DoNotSendCallbacks,
SniffContent, BufferData));
> +    userSheet->load(this, /*incremental*/ false, SkipSecurityCheck);

Wouldn't it be better if ResourceLoaderOptions were made a parameter of load()
instead of having a setter on CachedResource? They are never used separately.
Maybe something to fix later, I realize it would require more refactoring.