[webkit-reviews] review granted: [Bug 67064] Unzip initialization lists and constructors in JSCell hierarchy (3/7) : [Attachment 105443] Fixing review issues

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 67064: Unzip initialization lists and constructors in JSCell hierarchy
(3/7)
https://bugs.webkit.org/show_bug.cgi?id=67064

Attachment 105443: Fixing review issues
https://bugs.webkit.org/attachment.cgi?id=105443&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=105443&action=review


> Source/JavaScriptCore/runtime/ErrorInstance.cpp:32
> +    finishCreation(globalData, UString("", 0));

This way of creating an empty string is so non-obvious that I think we should
probably put a function in UString.h to do it or some other way that won’t look
so strange at the call site. Need not be part of this patch, though. Follow-up
seems better.