[webkit-reviews] review denied: [Bug 67051] Fix assertion when running debug build of Mac platform DRT. : [Attachment 105387] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied asvitkine at chromium.org's request
for review:
Bug 67051: Fix assertion when running debug build of Mac platform DRT.
https://bugs.webkit.org/show_bug.cgi?id=67051

Attachment 105387: Patch
https://bugs.webkit.org/attachment.cgi?id=105387&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105387&action=review


I'm confused. Is there something special that one needs to do to hit this
assertion? Mac debug build is how I'm running DRT, and I haven't seen it fire.

> Source/WebCore/bindings/js/ScriptController.cpp:193
>	   windowShell->window()->willRemoveFromWindowShell();
> -	   windowShell->setWindow(m_frame->domWindow());
> +	   if (m_frame->domWindow() != windowShell->impl())
> +	       windowShell->setWindow(m_frame->domWindow());

This can not be quite correct, because we tell JSDOMWindow that it will be
removed from window shell, but don't fulfill the promise.

I would need to see how the assertion fails (and then probably consult with
Geoff) to suggest a better approach, but it's likely that we should avoid
calling clearWindowShell altogether.