[webkit-reviews] review granted: [Bug 67063] Fold _webkit_initWithDomain into _webkit_errorWithDomain in WebKit2 : [Attachment 105403] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 26 14:02:55 PDT 2011


Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 67063: Fold _webkit_initWithDomain into _webkit_errorWithDomain in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=67063

Attachment 105403: Patch
https://bugs.webkit.org/attachment.cgi?id=105403&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=105403&action=review


>> Source/WebKit2/WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:88
>> +	return [[[NSError alloc] initWithDomain:domain code:code userInfo:dict]
autorelease];
> 
> Why the change from self to NSError?

I'd like to know this too! (Not that it matters since nobody subclasses NSError
in the web process).


More information about the webkit-reviews mailing list