[webkit-reviews] review granted: [Bug 66787] SelectElementData: Reorder members to reduce memory usage. : [Attachment 104866] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 23 11:00:10 PDT 2011
Darin Adler <darin at apple.com> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 66787: SelectElementData: Reorder members to reduce memory usage.
https://bugs.webkit.org/show_bug.cgi?id=66787
Attachment 104866: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=104866&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
While this does make the class smaller, I am concerned that it might also make
the class a bit harder to understand.
Also, I think it might be easy to make the class even smaller since a UChar
could share storage with some of the bools. Or the bools could be made
bitfields.
More information about the webkit-reviews
mailing list