[webkit-reviews] review granted: [Bug 65330] Remove auth-related functions from SubresourceLoaderClient : [Attachment 104190] Remove getShouldUseCredentialStorage() - with more ChangeLog

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 65330: Remove auth-related functions from SubresourceLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=65330

Attachment 104190: Remove getShouldUseCredentialStorage() - with more ChangeLog
https://bugs.webkit.org/attachment.cgi?id=104190&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I'm feeling conflicted about this patch:
1. When looking at ResourceLoader code, it's unnatural to expect that some
policy choices are overridden by a subclass. So, getting rid of that is good.
2. The weird check for m_request.allowCookies() is indeed weird. We had very
clear and straightforward code in the client.

I'm going to say r+, but could the real answer be to move the client call from
SubresourceLoaderClient to ResourceLoaderClient, clarifying control flow in
this way?