[webkit-reviews] review granted: [Bug 66723] Add handling of mix-width and max-width for flexitems : [Attachment 104748] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 66723: Add handling of mix-width and max-width for flexitems
https://bugs.webkit.org/show_bug.cgi?id=66723

Attachment 104748: Patch
https://bugs.webkit.org/attachment.cgi?id=104748&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=104748&action=review


r=me

> Source/WebCore/rendering/RenderFlexibleBox.cpp:187
> +    LayoutUnit flexboxAvailableLogicalWidth = availableLogicalWidth();

Add a FIXME: Deal with writing-modes above this availableLogicalWidth() line,
since that's the wrong axis to be looking at if writing-mode is vertical-lr and
the box orientation is explicitly horizontal.

> Source/WebCore/rendering/RenderFlexibleBox.h:58
> +    bool runFreeSpaceAllocationAlgorithm(LayoutUnit& availableFreeSpace,
float& totalPositiveFlexibility, float& totalNegativeFlexibility,
InflexibleFlexItemSize&);

Seems like kind of a generic name for only dealing with horizontal. I don't
know if you plan to put vertical in here too though. If so, then don't worry
about it.