[webkit-reviews] review granted: [Bug 66784] HTMLImageElement: Reorder members to reduce memory usage. : [Attachment 104864] Proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 66784: HTMLImageElement: Reorder members to reduce memory usage.
https://bugs.webkit.org/show_bug.cgi?id=66784

Attachment 104864: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=104864&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This change is OK.

But really ismap is just the cached result of hasAttribute(ismapAttr). It would
be better to get rid of the boolean entirely and just call
hasAttribute(ismapAttr) instead.

We could do something similar for usemap too. Generally speaking there is
little value to caching a copy of an attribute unless there’s something
super-performance-critical. For m_name and m_id this may be justified since
it’s critical to know what the old value of the attribute was when it changes,
but even there I think we might be able to optimize the storage out.