[webkit-reviews] review granted: [Bug 66751] [Chromium]WebWorkerClientImpl should always invoke InspectorIntrumentation on main thread : [Attachment 104803] Indentation fixed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 23 01:50:25 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has granted Dmitry Lomov
<dslomov at google.com>'s request for review:
Bug 66751: [Chromium]WebWorkerClientImpl should always invoke
InspectorIntrumentation on main thread
https://bugs.webkit.org/show_bug.cgi?id=66751

Attachment 104803: Indentation fixed
https://bugs.webkit.org/attachment.cgi?id=104803&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Looks good. Could you please add ASSERT(isMainThread()) into
instrumentationForPage(Page* page) (InstrumentingAgents.cpp) as a drive by?
That way it'll hit us prior to thread sanitizer next time.


More information about the webkit-reviews mailing list