[webkit-reviews] review denied: [Bug 37768] Web Inspector: differentiate element highlight colors for margin and padding : [Attachment 104677] [PATCH] Commented method removed

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 37768: Web Inspector: differentiate element highlight colors for margin and
padding
https://bugs.webkit.org/show_bug.cgi?id=37768

Attachment 104677: [PATCH] Commented method removed
https://bugs.webkit.org/attachment.cgi?id=104677&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104677&action=review


> Source/WebCore/inspector/DOMNodeHighlighter.cpp:119
> +    if (hasBorder && (!hasPadding || borderQuad != paddingQuad)) {

I'd rather get rid of this logic.

> Source/WebCore/inspector/Inspector.json:1064
> +		       { "name": "showInfo", "type": "boolean", "description":
"Whether the node info tooltip should be shown." },

optional: true, false by default.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1089
> +	   m_highlightData = adoptPtr(new HighlightData());

Could you make node and rect belong to this data as well?