[webkit-reviews] review granted: [Bug 65925] MediaStream API: add createObjectURL functionality : [Attachment 104694] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 65925: MediaStream API: add createObjectURL functionality
https://bugs.webkit.org/show_bug.cgi?id=65925

Attachment 104694: Patch
https://bugs.webkit.org/attachment.cgi?id=104694&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104694&action=review


> Source/WebCore/dom/ScriptExecutionContext.cpp:400
> +    mediaStreamRegistry().registerMediaStreamURL(publicURL, stream);
> +    m_publicStreamURLs.add(publicURL.string());

It's slightly unfortunate that we need to register this URL in two places, but
I don't see how to avoid that.

> Source/WebCore/platform/MediaStreamRegistry.h:42
> +    PassRefPtr<MediaStream> mediaStream(const KURL&) const;

Any particular reason why this returns a PassRefPtr rather than a raw pointer? 
We're not transferring ownership here.

> Source/WebCore/platform/MediaStreamRegistry.h:45
> +    // Currently assuming that the URLs keep alive their associated Streams.


How is that enforced?  (Technically comments should be complete sentences.)