[webkit-reviews] review granted: [Bug 66682] garden-o-matic's relative time display should be updated regularly. : [Attachment 104693] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 66682: garden-o-matic's relative time display should be updated regularly.
https://bugs.webkit.org/show_bug.cgi?id=66682

Attachment 104693: Patch
https://bugs.webkit.org/attachment.cgi?id=104693&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104693&action=review


>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/script
s/ui.js:30
> +var kTimeUpdateFrequencyInMilliseconds = 1000;

Should this be in config ?

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/script
s/ui.js:183
> +    Array.prototype.forEach.call(document.querySelectorAll("time"),
function(time) {

Do we want to add a class name here?  It seems like we could use other <time>
elements that don't derive from ui.Time