[webkit-reviews] review denied: [Bug 66650] [Qt] Flash in a QGraphicsWebView using OpenGL is slow : [Attachment 104664] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Christophe Oosterlynck
<tiftof at gmail.com>'s request for review:
Bug 66650: [Qt] Flash in a QGraphicsWebView using OpenGL is slow
https://bugs.webkit.org/show_bug.cgi?id=66650

Attachment 104664: Patch
https://bugs.webkit.org/attachment.cgi?id=104664&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=104664&action=review


> Source/WebCore/ChangeLog:4
> +	   Plugins are drawn on QPixmap instead of X11Pixmap when OpenGL
backend is used.
> +	   https://bugs.webkit.org/show_bug.cgi?id=66650

Please expand about what the patch actually does.

> Source/WebCore/plugins/qt/PluginViewQt.cpp:167
> +	       // Create QPixmap (to be used when paintengine is OpenGL)
> +	       m_pixmap = QPixmap(m_windowRect.width(), m_windowRect.height());

> +	       // Create X11 pixmap
>	       if (m_drawable)
>		   XFreePixmap(QX11Info::display(), m_drawable);

So, if we're on Linux we keep two pixmaps alive all the time? Sounds memory
inefficient.

> Source/WebCore/plugins/qt/PluginViewQt.cpp:288
> +    bool bUseX11Pixmap = true;

No Hungarian prefixes please :)

> Source/WebCore/plugins/qt/PluginViewQt.cpp:299
> +	   qtDrawable = QPixmap::fromX11Pixmap(m_drawable,
QPixmap::ExplicitlyShared);

This is cheap, but not free. Doing it for every draw is not efficient.