[webkit-reviews] review denied: [Bug 65925] MediaStream API: add createObjectURL functionality : [Attachment 104653] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 22 10:30:42 PDT 2011
Adam Barth <abarth at webkit.org> has denied Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 65925: MediaStream API: add createObjectURL functionality
https://bugs.webkit.org/show_bug.cgi?id=65925
Attachment 104653: Patch
https://bugs.webkit.org/attachment.cgi?id=104653&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104653&action=review
> Source/WebCore/dom/ScriptExecutionContext.cpp:390
> +static const String kMediaStreamFragment = "mediastream";
This is still a static initializer. These are forbidden in WebKit.
> Source/WebCore/dom/ScriptExecutionContext.cpp:399
> + // This makes it faster to detect that this URL points to a MediaStream.
> + publicURL.setFragmentIdentifier(kMediaStreamFragment);
I though you removed this hack? /me is confused.
More information about the webkit-reviews
mailing list