[webkit-reviews] review granted: [Bug 65587] Implemented skia support for caching resizes of cropped images. : [Attachment 104611] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted John Bates
<jbates at google.com>'s request for review:
Bug 65587: Implemented skia support for caching resizes of cropped images.
https://bugs.webkit.org/show_bug.cgi?id=65587

Attachment 104611: Patch
https://bugs.webkit.org/attachment.cgi?id=104611&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104611&action=review


> Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp:89
> +    m_resizedImage.extractSubset(&visibleBitmap, destVisibleSubset);

i take it that extractSubset does no work if the desired subset is everything?

this is so much clearer.  thanks!

R=me