[webkit-reviews] review requested: [Bug 66361] Pass --makeargs of build-webkit to chromium linux builder : [Attachment 104614] new patch

[bugzilla-daemon at webkit.org]

Xianzhu Wang <wangxianzhu at chromium.org> has asked  for review:
Bug 66361: Pass --makeargs of build-webkit to chromium linux builder
https://bugs.webkit.org/show_bug.cgi?id=66361

Attachment 104614: new patch
https://bugs.webkit.org/attachment.cgi?id=104614&action=review

------- Additional Comments from Xianzhu Wang <wangxianzhu at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104145&action=review


>> Tools/Scripts/webkitdirs.pm:1834
>> +	my $makeArgs = "-j$numCpus";
> 
> Nit: We end up add -j$numCpus below so you don't need to set the value here.

Sorry this was my mistake that I forgot to remove the latter assignment.

>> Tools/Scripts/webkitdirs.pm:1839
>> +	}
> 
> This could be:
> for (@options) {
>    $makeArgs = $1 if /^--makeargs=(.*)/;
> }

Thanks. Done.