[webkit-reviews] review granted: [Bug 61289] AX WK2 Regression: WebKit outputs incorrect AX position in frames/iframes : [Attachment 104548] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 61289: AX WK2 Regression: WebKit outputs incorrect AX position in
frames/iframes
https://bugs.webkit.org/show_bug.cgi?id=61289

Attachment 104548: patch
https://bugs.webkit.org/attachment.cgi?id=104548&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=104548&action=review


Not sure why the EWS couldn’t apply the patch. Would be better to put up a
patch that it can apply.

> Source/WebCore/accessibility/mac/AccessibilityObjectWrapper.mm:1402
> +	   if (m_object->page())
> +	       point =
m_object->page()->chrome()->windowToScreen(rect).location();

If page is 0, then point is left uninitialized. Then we’ll return a random
point. We could just use rect.location() in that case, or initialize the point
to 0,0.

> Source/WebCore/accessibility/AccessibilityObject.cpp:990
> +    Document *document = this->document();

It should be Document*, with the * next to the Document.