[webkit-reviews] review denied: [Bug 65834] NRWT should support cascading expectations : [Attachment 104311] make able the wk2 ports to share their common expectations in the wk2 platform

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has denied Kristóf Kosztyó
<kkristof at inf.u-szeged.hu>'s request for review:
Bug 65834: NRWT should support cascading expectations
https://bugs.webkit.org/show_bug.cgi?id=65834

Attachment 104311: make able the wk2 ports to share their common expectations
in the wk2 platform
https://bugs.webkit.org/attachment.cgi?id=104311&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104311&action=review


> Tools/Scripts/webkitpy/layout_tests/port/webkit.py:370
> +	   return result

I'm pretty sure that by coding things this way you're ignoring any modifiers
that might be set on the lines, and so if you have a line in the wk2 file like:


BUGX MAC : foo/bar.html = PASS

and a line in the regular file like:

BUGY WIN : foo/bar.html = TEXT

you will throw away the second line, which would be wrong.

I'm not sure that trying to manually implement a cascade through concatenation
and a limited form of deduplication is a fruitful way of doing things. I think
we probably need to implement "proper" support for cascading that is aware of
the modifiers.