[webkit-reviews] review granted: [Bug 66288] Selecting all and inserting text into a page with a frameset leads to a NULL ptr : [Attachment 104187] Patch

Wed Aug 17 11:01:54 PDT 2011

Tony Chang <tony at chromium.org> has granted Wyatt Carss <wcarss at chromium.org>'s
request for review:
Bug 66288: Selecting all and inserting text into a page with a frameset leads
to a NULL ptr
https://bugs.webkit.org/show_bug.cgi?id=66288

Attachment 104187: Patch
https://bugs.webkit.org/attachment.cgi?id=104187&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104187&action=review

> LayoutTests/editing/inserting/insert-text-into-empty-frameset-crash.html:1
> +<html>

Nit: <DOCTYPE html>

> Source/WebCore/editing/InsertTextCommand.cpp:110
>	   deleteSelection(false, true, true, false);

Wow, this function should take enums rather than 4 bools. (Unrelated to your
patch, but would be a good place for a refactoring patch.)