[webkit-reviews] review granted: [Bug 66307] Support reset in WebCore::Internals : [Attachment 104078] fix patch 2

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Chang Shu
<cshu at webkit.org>'s request for review:
Bug 66307: Support reset in WebCore::Internals
https://bugs.webkit.org/show_bug.cgi?id=66307

Attachment 104078: fix patch 2
https://bugs.webkit.org/attachment.cgi?id=104078&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104078&action=review


> Source/WebCore/testing/js/WebCoreTestSupport.cpp:54
> +    Internals * internals =
toInternals(globalObject->getDirect(exec->globalData(), Identifier(exec,
"internals")));

Now that we're using it in more than one place, the literal should probably be
a constant in this file.

> Source/WebCore/testing/v8/WebCoreTestSupport.cpp:53
> +    v8::Handle<v8::Object> object =
v8::Handle<v8::Object>::Cast(context->Global()->Get(v8::String::New("internals"
)));

Ditto.