[webkit-reviews] review denied: [Bug 66218] Add two sample mismatch reftests to make sure that mismatch reftests work. : [Attachment 103991] Update test_expectations.txt on all platforms.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 16 09:25:48 PDT 2011


Tony Chang <tony at chromium.org> has denied Hayato Ito <hayato at chromium.org>'s
request for review:
Bug 66218: Add two sample mismatch reftests to make sure that mismatch reftests
work.
https://bugs.webkit.org/show_bug.cgi?id=66218

Attachment 103991: Update test_expectations.txt on all platforms.
https://bugs.webkit.org/attachment.cgi?id=103991&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103991&action=review


> LayoutTests/platform/chromium/test_expectations.txt:467
> +WONTFIX : fast/harness/sample-fail-mismatch-reftest.html = IMAGE

Oh, can you just add these to Skipped files instead of test_expectations.txt? 
On the other ports, NRWT uses both Skipped and test_expectations.txt and I
think so far the other ports are primarily using Skipped.

Sorry for the back and forth.


More information about the webkit-reviews mailing list