[webkit-reviews] review granted: [Bug 66309] TestFailures thinks all tests passed in http://build.webkit.org/builders/Lion%20Intel%20Debug%20(Tests)/builds/136 : [Attachment 104055] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 16 09:21:26 PDT 2011


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 66309: TestFailures thinks all tests passed in
http://build.webkit.org/builders/Lion%20Intel%20Debug%20(Tests)/builds/136
https://bugs.webkit.org/show_bug.cgi?id=66309

Attachment 104055: Patch
https://bugs.webkit.org/attachment.cgi?id=104055&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104055&action=review


r=me

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builde
r_unittests.js:183
> +test("getNumberOfFailingTests treats unfinished test runs  as errors", 4,
function() {

Nit:  Extra space between "runs  as".


More information about the webkit-reviews mailing list