[webkit-reviews] review granted: [Bug 66068] Web Inspector: console loses focus upon reloading the page from the inspector. : [Attachment 103760] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 66068: Web Inspector: console loses focus upon reloading the page from the
inspector.
https://bugs.webkit.org/show_bug.cgi?id=66068

Attachment 103760: Patch
https://bugs.webkit.org/attachment.cgi?id=103760&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103760&action=review


Please make sure all usages and implementations of revealAndSelect has
consistent signatures.

> Source/WebCore/inspector/front-end/ElementsPanel.js:183
> +	   this.selectDOMNode(null);

this.selectDOMNode(null, false); ?

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:80
> +    selectedDOMNode: function()

Why is it not a getter?

> Source/WebCore/inspector/front-end/ProfilesPanel.js:393
> +	   profile._profilesTreeElement.revealAndSelect(false);

Remove the false parameter?

> Source/WebCore/inspector/front-end/treeoutline.js:439
> +TreeOutline.prototype.revealAndSelect = function()

Add omitFocus parameter?