[webkit-reviews] review denied: [Bug 66131] Web Inspector: maintain visible view hierarchy and dispatch common view events automatically : [Attachment 103756] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 66131: Web Inspector: maintain visible view hierarchy and dispatch common
view events automatically
https://bugs.webkit.org/show_bug.cgi?id=66131

Attachment 103756: patch
https://bugs.webkit.org/attachment.cgi?id=103756&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103756&action=review


> Source/WebCore/inspector/front-end/ConsoleView.js:38
> +    drawer.setParent(this);

ConsoleView is not a parent of drawer. Is full screen mode a drawer?

> Source/WebCore/inspector/front-end/Drawer.js:183
> +	       WebInspector.currentPanel.dispatchToVisibleViews("resize");

I like the way it was.

> Source/WebCore/inspector/front-end/Drawer.js:363
> + }

extra space

> Source/WebCore/inspector/front-end/NetworkPanel.js:643
> +    viewActivated: function()

What is view activated?

> Source/WebCore/inspector/front-end/NetworkPanel.js:1388
> +	       this.visibleView.setParent(null);

You should do addChildView instead.

> Source/WebCore/inspector/front-end/View.js:137
> +	   this._visibleChildren.push(view);

I don't think you should distinguish between visible views and non-visible
views here.