[webkit-reviews] review denied: [Bug 65824] Repeated copy and paste result in nested font elements : [Attachment 103296] Removed chromium-specific result for paste-text-011
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 8 17:06:13 PDT 2011
Tony Chang <tony at chromium.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 65824: Repeated copy and paste result in nested font elements
https://bugs.webkit.org/show_bug.cgi?id=65824
Attachment 103296: Removed chromium-specific result for paste-text-011
https://bugs.webkit.org/attachment.cgi?id=103296&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103296&action=review
Some small style nits and questions about some of the changed results.
> Source/WebCore/editing/EditingStyle.cpp:640
> + DEFINE_STATIC_LOCAL(Vector<OwnPtr<HTMLElementEquivalent> >,
HTMLElementEquivalents, ());
What's the benefit of OwnPtr here? Don't we want to just leak it on exit?
> Source/WebCore/editing/EditingStyle.cpp:759
> + elementIsSpanOrElementEquivalent = i <
HTMLElementEquivalents.size();
Nit: Maybe just set elementIsSpanOrElementEquivalent = true; before you break
(could then also put the declaration of |i| in the for statement)?
> Source/WebCore/editing/EditingStyle.cpp:786
> + if (editingInheritableProperties[i] == it->id())
> + matched = true;
Should we break here?
> Source/WebCore/editing/ReplaceSelectionCommand.cpp:960
> + if (RefPtr<Node> nodeToSplitTo =
highestEnclosingNodeOfType(insertionPos, isInlineNodeWithStyle,
CannotCrossEditingBoundary,
Is it possible to write a test to verify that this editability check is
correct?
>
LayoutTests/editing/pasteboard/paste-after-inline-style-element-expected.txt:8
> +| "line 2<#selection-caret>"
> +| "Â "
Is this expected? It looks like it was bold but no longer is.
> LayoutTests/editing/pasteboard/paste-text-with-style-2-expected.txt:21
> +| <font>
> +| class="Apple-style-span"
> +| color="#ff0000"
Why did font move to the outsize here?
> LayoutTests/editing/pasteboard/paste-with-redundant-style-expected.txt:12
> +| <em>
> +| "rocks<#selection-caret>"
Why isn't this bold? It looks like it's bold before.
More information about the webkit-reviews
mailing list