[webkit-reviews] review granted: [Bug 65878] scm.delete should delete empty parent directories as well : [Attachment 103295] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 65878: scm.delete should delete empty parent directories as well
https://bugs.webkit.org/show_bug.cgi?id=65878

Attachment 103295: Patch
https://bugs.webkit.org/attachment.cgi?id=103295&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103295&action=review


LGTM if you fix the self._filesystem issues.

> Tools/Scripts/webkitpy/common/checkout/scm/svn.py:179
> +	   if set(os.listdir(path)) - self._svn_metadata_files:

Seems this should be self._filtesystem.listdir().  Also do we have other
ignored files we should exclude?

> Tools/Scripts/webkitpy/common/checkout/scm/svn.py:182
> +	   dirname = os.path.dirname(path)

self._filesystem.

> Tools/Scripts/webkitpy/common/checkout/scm/svn.py:188
> +	   abs_path = os.path.abspath(path)
> +	   parent, base = os.path.split(abs_path)

more self._filesystem.