[webkit-reviews] review granted: [Bug 65586] Chromium Mac: Make sure scrollbars flash when web page loads : [Attachment 102726] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 3 14:27:33 PDT 2011


James Robinson <jamesr at chromium.org> has granted Sailesh Agrawal
<sail at chromium.org>'s request for review:
Bug 65586: Chromium Mac: Make sure scrollbars flash when web page loads
https://bugs.webkit.org/show_bug.cgi?id=65586

Attachment 102726: Patch
https://bugs.webkit.org/attachment.cgi?id=102726&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102726&action=review


> Source/WebCore/ChangeLog:6
> +	   https://bugs.webkit.org/show_bug.cgi?id=65586
> +
> +	   On slow web pages scrollbars wouldn't flash when the page was done
loading. The problem was that we were flashing the scrollbar 0.1 second after
the load operation had started. If the page was slow to load then we might not
have scrollbars to flash. To work around this I added an extra check to make
sure that we had indeed finished loading the page before flashing the
scrollbars.

You need a 'Reviewed by' line here or the commit bot will reject you.


More information about the webkit-reviews mailing list