[webkit-reviews] review granted: [Bug 65575] Chromium Mac: Fix position of search tickmarks : [Attachment 102704] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 3 14:28:19 PDT 2011


James Robinson <jamesr at chromium.org> has granted Sailesh Agrawal
<sail at chromium.org>'s request for review:
Bug 65575: Chromium Mac: Fix position of search tickmarks
https://bugs.webkit.org/show_bug.cgi?id=65575

Attachment 102704: Patch
https://bugs.webkit.org/attachment.cgi?id=102704&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102704&action=review


> Source/WebCore/ChangeLog:8
> +	   https://bugs.webkit.org/show_bug.cgi?id=65575
> +
> +	   This change adjusts the position of search tickmarks so that they
are correctly centered.
> +
> +	   Also, insetting the tickmark rect by 5 pixels caused tickmarks on
the overlay scrollbar to look very small. I changed this to inset by 4 pixels
instead. The tickmark is the same width as the overlay scrollbar which looks
much better.

You need a 'Reviewed by' line. Is this behavior different from the mac
scrollbar theme?


More information about the webkit-reviews mailing list