[webkit-reviews] review granted: [Bug 65633] Add "optimize-expectations" command to webkit-patch. : [Attachment 102807] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 65633: Add "optimize-expectations" command to webkit-patch.
https://bugs.webkit.org/show_bug.cgi?id=65633

Attachment 102807: Patch
https://bugs.webkit.org/attachment.cgi?id=102807&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102807&action=review


> Tools/Scripts/webkitpy/tool/commands/expectations.py:31
> +import os.path
> +import shutil
> +import urllib

These don't seem to be needed.

> Tools/Scripts/webkitpy/tool/commands/expectations.py:35
> +from webkitpy.layout_tests.models.test_configuration import *
> +from webkitpy.layout_tests.models.test_expectations import *

Star imports are forbidden outside of unittest files.

> Tools/Scripts/webkitpy/tool/commands/expectations.py:51
> +	  
port.filesystem.write_text_file(port.path_to_test_expectations_file(),
TestExpectationSerializer.list_to_string(expectation_lines, converter))

You should get the filesystem from the tool.