[webkit-reviews] review denied: [Bug 65634] Generate WebCoreHeaderDetection.h on Windows to define WTF_USE_AVFOUNDATION : [Attachment 102810] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has denied Jeff Miller
<jeffm at apple.com>'s request for review:
Bug 65634: Generate WebCoreHeaderDetection.h on Windows to define
WTF_USE_AVFOUNDATION
https://bugs.webkit.org/show_bug.cgi?id=65634

Attachment 102810: Patch
https://bugs.webkit.org/attachment.cgi?id=102810&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=102810&action=review


> Source/WebCore/DerivedSources.make:984
> +	if [ -f "$(WEBKITLIBRARIESDIR)/include/AVFoundationCF/AVCFBase.h" ];
then echo "#define WTF_USE_AVFOUNDATION 0" > $@; else echo > $@; fi

I think we want to define a HAVE_* macro in WebCoreHeaderDetection.h, rather
than a WTF_USE_* macro. WebCoreHeaderDetection.h should be all about what
headers are available, not about policy decisions for which headers to use.
config.h should have some logic like

#if PLATFORM(WIN) && HAVE(AVCF)
#define WTF_USE_AVFOUNDATION
#endif