[webkit-reviews] review granted: [Bug 59717] Web Inspector: include script end line:column in scriptParsed parameters. : [Attachment 91525] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 59717: Web Inspector: include script end line:column in scriptParsed
parameters.
https://bugs.webkit.org/show_bug.cgi?id=59717

Attachment 91525: Patch
https://bugs.webkit.org/attachment.cgi?id=91525&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91525&action=review

> Source/WebCore/bindings/v8/DebuggerScript.js:96
> +	   endColumn = script.source.length - (script.line_ends[lineCount - 2]
+ 1);

Do we really need this +1?

> Source/WebCore/inspector/InspectorDebuggerAgent.h:123
> +    virtual void didParseSource(const String& sourceID, const String& url,
const String& data,  int startLine, int startColumn, int endLine, int
endColumn, bool isContentScript);

Remove extra space before int startLine.