[webkit-reviews] review requested: [Bug 58127] Web Inspector: missing fields in HAR : [Attachment 91665] Patch implementing some of the missing functionality.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 29 04:51:42 PDT 2011


Mike West <mkwst at chromium.org> has asked  for review:
Bug 58127: Web Inspector: missing fields in HAR
https://bugs.webkit.org/show_bug.cgi?id=58127

Attachment 91665: Patch implementing some of the missing functionality.
https://bugs.webkit.org/attachment.cgi?id=91665&action=review

------- Additional Comments from Mike West <mkwst at chromium.org>
After talking with Andrey earlier in the week, I've implemented some of the
required functionality.

This patch really just hits the trivial bits that were recently implemented.
Most notably, cache attributes are missing entirely from this patch; it'll take
a little more work than I expected to extract them in a reasonable way, and I'd
like to break that work out into a separate patch to follow (probably sometime
next week).

I didn't see any tests that hit this functionality, and I'm not familiar enough
with WebKit to know where to add them myself. If you can point me in the right
direction, I'd appreciate it.

Setting r? for feedback on the additions, though I expect r- for the tests, as
noted above. :)


More information about the webkit-reviews mailing list