[webkit-reviews] review granted: [Bug 56627] implement image-rendering: optimize-contrast (with a vendor prefix) as defined in CSS3 image values : [Attachment 91614] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Mike Lawther
<mikelawther at chromium.org>'s request for review:
Bug 56627: implement image-rendering: optimize-contrast (with a vendor prefix)
as defined in CSS3 image values
https://bugs.webkit.org/show_bug.cgi?id=56627

Attachment 91614: Patch
https://bugs.webkit.org/attachment.cgi?id=91614&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=91614&action=review

What platform did you generate the image results on? Did you check Mac with CG?


> Source/WebCore/rendering/style/RenderStyle.h:214
>	   // 45 bits

No longer 45, right?

> Source/WebCore/rendering/style/RenderStyleConstants.h:429
> +enum EImageRendering { IR_AUTO, IR_OPTIMIZESPEED, IR_OPTIMIZEQUALITY,
IR_OPTIMIZECONTRAST };

UGLIEST enum values ever. Can you prettify them? No need for all caps.