[webkit-reviews] review granted: [Bug 59752] Allow Localized Date Strings for Date Input Fields : [Attachment 91616] [PATCH] Add LocalizedDate Allow Formatting + Parsing

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 59752: Allow Localized Date Strings for Date Input Fields
https://bugs.webkit.org/show_bug.cgi?id=59752

Attachment 91616: [PATCH] Add LocalizedDate Allow Formatting + Parsing
https://bugs.webkit.org/attachment.cgi?id=91616&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91616&action=review

> Source/WebCore/platform/text/LocalizedDate.h:38
> +// Parses a string representation of a date string localized
> +// for the browser's current locale for a particular date type.
> +// If the input string is not valid or an implementation doesn't
> +// support localized dates, this function returns an empty string.
> +String parseLocalizedDate(const String&, DateComponents::Type);

Should add a comment about what should be returned for valid inputs.