[webkit-reviews] review denied: [Bug 59696] Chromium DevTools: Fix network panel timing/size/headers tests. : [Attachment 91482] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 28 10:47:27 PDT 2011
Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 59696: Chromium DevTools: Fix network panel timing/size/headers tests.
https://bugs.webkit.org/show_bug.cgi?id=59696
Attachment 91482: Patch
https://bugs.webkit.org/attachment.cgi?id=91482&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91482&action=review
> Source/WebKit/chromium/src/js/Tests.js:533
> + test.assertTrue(resource.transferSize === 219 ||
resource.transferSize === 221,
219 or 221? :) why?
> Source/WebKit/chromium/src/js/Tests.js:534
> + "Incorrect total encoded data length: should be 219 (or
221), but was resource.transferSize=" + resource.transferSize + ".");
weird indent.
> Source/WebKit/chromium/src/js/Tests.js:559
> + "Incorrect total encoded data length: should be 219 (or
221), but was resource.transferSize=" + resource.transferSize + ".");
ditto
More information about the webkit-reviews
mailing list