[webkit-reviews] review granted: [Bug 59476] Web Inspector: breakpoints set in original and formatted scripts are messed up after navigation. : [Attachment 91485] Remove all breakpoints when formatting mode is changed.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 28 10:46:14 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 59476: Web Inspector: breakpoints set in original and formatted scripts are
messed up after navigation.
https://bugs.webkit.org/show_bug.cgi?id=59476

Attachment 91485: Remove all breakpoints when formatting mode is changed.
https://bugs.webkit.org/attachment.cgi?id=91485&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91485&action=review

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:346
> +	   if (callback)

Why did you make this call synchronous?

> Source/WebCore/inspector/front-end/ScriptsPanel.js:478
> +	   for (var id in this._sourceFileIdToSourceFrame) {

Is this change related?


More information about the webkit-reviews mailing list