[webkit-reviews] review requested: [Bug 38696] Unfocused contenteditable element still receives keyboard events and gets modified : [Attachment 91338] Patch with updated expectations

[bugzilla-daemon at webkit.org]

Levi Weintraub <leviw at chromium.org> has asked  for review:
Bug 38696: Unfocused contenteditable element still receives keyboard events and
gets modified
https://bugs.webkit.org/show_bug.cgi?id=38696

Attachment 91338: Patch with updated expectations
https://bugs.webkit.org/attachment.cgi?id=91338&action=review

------- Additional Comments from Levi Weintraub <leviw at chromium.org>
(In reply to comment #20)
> Apple’s QA process might include some testing of third party applications,
but probably long after any code change; there’s no team I can assign this to.
My department at Apple doesn’t have the resources to test all those
applications and Dashboard widgets; normally we use technical strategies that
minimize the need for that kind of extensive testing.

I did the following testing with this change:

1) Ran Dashboard with this change, loaded every Widget that ships with Snow
Leopard, and manually attempted to exhaust the functionality of each.

2) Ran the BrowserScope RTE suite (http://www.browserscope.org/richtext2/test)
and validated we didn't regress.

3) Validated that forms that automatically set focus while you fill them out
still work properly (tested Amazon, Yahoo, Google Checkout, and PayPal payment
forms).

4) Validated that Rich Text Editors continue to work properly (TinyMCE,
Aloha-Editor).

Throughout all this testing, I ran into no issues. Once again, for the web
ideally we'd get this change into a Chrome beta to ferret out issues on the
Web.

This doesn't address concerns about Mac Apps with embedded WebViews. If this
isn't something you can QA, we could make this an editing behavior, but I don't
think that would be a clean solution.