[webkit-reviews] review denied: [Bug 59249] Colliding isinf/isnan between C99 and C++0x with GCC 4.6.0 : [Attachment 90792] namespacestdisnan.diff

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Xan Lopez <xan.lopez at gmail.com>'s
request for review:
Bug 59249: Colliding isinf/isnan between C99 and C++0x with GCC 4.6.0
https://bugs.webkit.org/show_bug.cgi?id=59249

Attachment 90792: namespacestdisnan.diff
https://bugs.webkit.org/attachment.cgi?id=90792&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=90792&action=review

>>> Source/JavaScriptCore/ChangeLog:9
>>> +	     used, since it can lead to ambiguity in C++0x compilers. See the
>> 
>> This is not a very maintainable rule, and following it makes the code base
less consistent. I hope that there is a better solution.
>> 
>> Is this a gcc bug, or expected behavior?
> 
> I can't really think of any, but there might be. My proposed long-term
solution of getting rid of math.h and always using std:: in front of the
functions also requires not to use "using namespace std;", at least in the
files where isnan/isinf are called, so it wouldn't be a huge improvement in
that regard, I suppose.

The right thing to do is to find a fix in MathExtras.h. The goal is to be able
to call isinf and isnan directly; there must be way to do that.

Please do *not* start making these changes to all the files using MathExtras.h.