[webkit-reviews] review denied: [Bug 58495] Change useLowQualityScale boolean in GraphicsContext to be an enum : [Attachment 89540] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Mike Lawther
<mikelawther at chromium.org>'s request for review:
Bug 58495: Change useLowQualityScale boolean in GraphicsContext to be an enum
https://bugs.webkit.org/show_bug.cgi?id=58495

Attachment 89540: Patch
https://bugs.webkit.org/attachment.cgi?id=89540&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89540&action=review

Need help understanding the low vs. none thing, otherwise this looks fine!

> Source/WebCore/platform/graphics/GraphicsContext.cpp:479
> -	   setImageInterpolationQuality(InterpolationLow);
> +	   setImageInterpolationQuality(InterpolationNone);

Why?

> Source/WebCore/platform/graphics/GraphicsContext.cpp:499
> -	   setImageInterpolationQuality(InterpolationLow);
> +	   setImageInterpolationQuality(InterpolationNone);

Why?

> Source/WebCore/rendering/RenderBoxModelObject.cpp:756
> +	       ScalingAlgorithm scaleAlgorithm = 
> +		   shouldPaintAtLowQuality(context, image.get(), bgLayer,
tileSize) ? ScalingNearestNeighbor : ScalingAuto;

We dont' really have a collumn limit for webkit.