[webkit-reviews] review denied: [Bug 57858] WebKit for Mac should always propagate a mouse release event to a subframe : [Attachment 88545] Patch and layout test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 26 16:37:26 PDT 2011


Maciej Stachowiak <mjs at apple.com> has denied Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 57858: WebKit for Mac should always propagate a mouse release event to a
subframe
https://bugs.webkit.org/show_bug.cgi?id=57858

Attachment 88545: Patch and layout test
https://bugs.webkit.org/attachment.cgi?id=88545&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
I think this is probably the right thing to do for most cases, but in the
splitter case that was the genesis of this bug, I am pretty sure sending a
mouseup at the end of splitter dragging can only possibly have bad effects even
if other browsers do it too.

Otherwise the code looks fine.

I guess you would also need to update the test and maybe make a separate test
for dragging a non-frame thing other than the splitter.


More information about the webkit-reviews mailing list