[webkit-reviews] review granted: [Bug 58416] [GTK] Implement UI client in minibrowser : [Attachment 89760] Updated patch acording to review

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 58416: [GTK] Implement UI client in minibrowser
https://bugs.webkit.org/show_bug.cgi?id=58416

Attachment 89760: Updated patch acording to review
https://bugs.webkit.org/attachment.cgi?id=89760&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89760&action=review

Looks good, but please fix the style errors before landing.

> Tools/MiniBrowser/gtk/BrowserWindow.c:406
> +static void browserWindowUIClientInit(BrowserWindow* window)

Please shift the asterisk over.

> Tools/MiniBrowser/gtk/main.c:32
> +static const gchar** uriArguments = NULL;

The asterisks should be on uriArguments.

> Tools/MiniBrowser/gtk/main.c:48
> +    GtkWidget* mainWindow = browser_window_new(webView);
> +    gchar* url = argumentToURL(uri);
> +    WKPageLoadURL(WKViewGetPage(webView), WKURLCreateWithUTF8CString(url));

Ditto

> Tools/MiniBrowser/gtk/main.c:66
> +    GOptionContext* context = g_option_context_new(NULL);

Ditto

> Tools/MiniBrowser/gtk/main.c:70
> +    GError* error = NULL;

Ditto. Please use 0 here instead of NULL.

> Tools/MiniBrowser/gtk/main.c:81
> +	   gint i;

Please just use int here.