[webkit-reviews] review granted: [Bug 59465] Port Mozilla's IndexedDB tests: readonly and read/write transactions : [Attachment 91120] patch with changelog and layouttest

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 26 16:19:28 PDT 2011


Tony Chang <tony at chromium.org> has granted Mark Pilgrim
<pilgrim at chromium.org>'s request for review:
Bug 59465: Port Mozilla's IndexedDB tests: readonly and read/write transactions
https://bugs.webkit.org/show_bug.cgi?id=59465

Attachment 91120: patch with changelog and layouttest
https://bugs.webkit.org/attachment.cgi?id=91120&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91120&action=review

>
third_party/WebKit/LayoutTests/storage/indexeddb/mozilla/readwrite-transactions
.html:121
> +    done();

It would be nice if on failure we still called done() so the test doesn't
timeout.  One way to do this is to have the onerror callback call done() before
calling unexpectedErrorCallback().


More information about the webkit-reviews mailing list